[SPARK-21089] [SQL] Fix DESC EXTENDED/FORMATTED to Show Table Properties #18294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
commented
Jun 14, 2017
| @@ -127,8 +127,9 @@ Provider parquet | |||
| Num Buckets 2 | |||
| Bucket Columns [`a`] | |||
| Sort Columns [`b`] | |||
| Properties [a=1, b=2] | |||
There was a problem hiding this comment.
Before the changes of this PR
gatorsmile
commented
Jun 14, 2017
| Location [not included in comparison]sql/core/spark-warehouse/t | ||
| Storage Properties [a=1, b=2] |
There was a problem hiding this comment.
After the change of this PR, both appear.
gatorsmile
commented
Jun 14, 2017
| @@ -127,8 +127,9 @@ Provider parquet | |||
| Num Buckets 2 | |||
| Bucket Columns [`a`] | |||
| Sort Columns [`b`] | |||
| Properties [a=1, b=2] | |||
| Table Properties [e=3] | |||
There was a problem hiding this comment.
After the change of this PR, both appear.
|
cc @cloud-fan |
|
Test build #78027 has started for PR 18294 at commit |
|
Test build #78025 has finished for PR 18294 at commit
|
|
the test failure is legitimate |
|
retest this please |
|
@cloud-fan That is by the first commit, whose output is generated by the codes before the fix. |
|
Test build #78053 has finished for PR 18294 at commit
|
|
LGTM. |
asfgit
pushed a commit
that referenced
this pull request
Jun 14, 2017
Since both table properties and storage properties share the same key values, table properties are not shown in the output of DESC EXTENDED/FORMATTED when the storage properties are not empty. This PR is to fix the above issue by renaming them to different keys. Added test cases. Author: Xiao Li <gatorsmile@gmail.com> Closes #18294 from gatorsmile/tableProperties. (cherry picked from commit df766a4) Signed-off-by: Xiao Li <gatorsmile@gmail.com>
dataknocker
pushed a commit
to dataknocker/spark
that referenced
this pull request
Jun 16, 2017
### What changes were proposed in this pull request? Since both table properties and storage properties share the same key values, table properties are not shown in the output of DESC EXTENDED/FORMATTED when the storage properties are not empty. This PR is to fix the above issue by renaming them to different keys. ### How was this patch tested? Added test cases. Author: Xiao Li <gatorsmile@gmail.com> Closes apache#18294 from gatorsmile/tableProperties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since both table properties and storage properties share the same key values, table properties are not shown in the output of DESC EXTENDED/FORMATTED when the storage properties are not empty.
This PR is to fix the above issue by renaming them to different keys.
How was this patch tested?
Added test cases.