Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-21345][SQL][TEST][test-maven][BRANCH-2.1] SparkSessionBuilderSuite should clean up stopped sessions. #18572

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

SparkSessionBuilderSuite should clean up stopped sessions. Otherwise, it leaves behind some stopped SparkContexts interfereing with other test suites using ShardSQLContext.

Recently, master branch fails consequtively.

How was this patch tested?

Pass the Jenkins with a updated suite.

`SparkSessionBuilderSuite` should clean up stopped sessions. Otherwise, it leaves behind some stopped `SparkContext`s interfereing with other test suites using `ShardSQLContext`.

Recently, master branch fails consequtively.
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/

Pass the Jenkins with a updated suite.

Author: Dongjoon Hyun <dongjoon@apache.org>

Closes #18567 from dongjoon-hyun/SPARK-SESSION.
@dongjoon-hyun
Copy link
Member Author

Hi, @cloud-fan and @gatorsmile .
This is a backport of #18567 . Since this will reduce the potential failures on unit tests, we had better have this in branch-2.1 for stability, too.

@SparkQA
Copy link

SparkQA commented Jul 8, 2017

Test build #79392 has finished for PR 18572 at commit 7dba32a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class SparkSessionBuilderSuite extends SparkFunSuite with BeforeAndAfterEach

@cloud-fan
Copy link
Contributor

thanks, merging to 2.1!

asfgit pushed a commit that referenced this pull request Jul 9, 2017
…uite should clean up stopped sessions.

## What changes were proposed in this pull request?

`SparkSessionBuilderSuite` should clean up stopped sessions. Otherwise, it leaves behind some stopped `SparkContext`s interfereing with other test suites using `ShardSQLContext`.

Recently, master branch fails consequtively.
- https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/

## How was this patch tested?

Pass the Jenkins with a updated suite.

Author: Dongjoon Hyun <dongjoon@apache.org>

Closes #18572 from dongjoon-hyun/SPARK-21345-BRANCH-2.1.
@dongjoon-hyun
Copy link
Member Author

Thank you for merging, @cloud-fan.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-21345-BRANCH-2.1 branch July 9, 2017 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants