Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-21366][SQL][TEST] Add sql test for window functions #18591

Closed
wants to merge 4 commits into from
Closed

[SPARK-21366][SQL][TEST] Add sql test for window functions #18591

wants to merge 4 commits into from

Conversation

jiangxb1987
Copy link
Contributor

@jiangxb1987 jiangxb1987 commented Jul 10, 2017 •
edited
Loading

What changes were proposed in this pull request?

Add sql test for window functions, also remove uncecessary test cases in WindowQuerySuite.

How was this patch tested?

Added window.sql and the corresponding output file.

@jiangxb1987 jiangxb1987 changed the title [SQL][TEST] Add sql test for window functions [SPARK-21366][SQL][TEST] Add sql test for window functions Jul 10, 2017
@gatorsmile
Copy link
Member

Anything we remove from the existing suite WindowQuerySuite?

@SparkQA
Copy link

SparkQA commented Jul 10, 2017

Test build #79471 has finished for PR 18591 at commit 2e3836c.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jiangxb1987
Copy link
Contributor Author

retest this please.

@jiangxb1987
Copy link
Contributor Author

@gatorsmile AFAIK the WindowQuerySuite is purposed to test the Hive compatibility, so I'm hesitate to remove any test cases from it.

@SparkQA
Copy link

SparkQA commented Jul 11, 2017

Test build #79484 has finished for PR 18591 at commit 2e3836c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jiangxb1987
Copy link
Contributor Author

also cc @cloud-fan

@gatorsmile
Copy link
Member

gatorsmile commented Jul 11, 2017 •
edited
Loading

At least these three test cases are not related to Hive compatibility in WindowQuerySuite

@jiangxb1987
Copy link
Contributor Author

Okay, let me remove them.

@SparkQA
Copy link

SparkQA commented Jul 11, 2017

Test build #79498 has finished for PR 18591 at commit a8b0065.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 11, 2017

Test build #79508 has finished for PR 18591 at commit f415e64.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 11, 2017

Test build #79512 has finished for PR 18591 at commit e58f68b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Jul 11, 2017
@jiangxb1987 @cloud-fan
[SPARK-21366][SQL][TEST] Add sql test for window functions
399aa01 
## What changes were proposed in this pull request?

Add sql test for window functions, also remove uncecessary test cases in `WindowQuerySuite`.

## How was this patch tested?

Added `window.sql` and the corresponding output file.

Author: Xingbo Jiang <xingbo.jiang@databricks.com>

Closes #18591 from jiangxb1987/window.

(cherry picked from commit 66d2168)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
@cloud-fan
Copy link
Contributor

thanks, mering to master/2.2!

We may have bug fixes for window functions in 2.2, and this test may be useful.

@asfgit asfgit closed this in 66d2168 Jul 11, 2017
@jiangxb1987 jiangxb1987 deleted the window branch July 11, 2017 14:41
MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
@jiangxb1987 @MatthewRBruce
[SPARK-21366][SQL][TEST] Add sql test for window functions
5a6129e 
## What changes were proposed in this pull request?

Add sql test for window functions, also remove uncecessary test cases in `WindowQuerySuite`.

## How was this patch tested?

Added `window.sql` and the corresponding output file.

Author: Xingbo Jiang <xingbo.jiang@databricks.com>

Closes apache#18591 from jiangxb1987/window.

(cherry picked from commit 66d2168)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jiangxb1987 @gatorsmile @SparkQA @cloud-fan