[SPARK-21377][YARN] Add a new configuration to extend AM classpath in yarn client mode #18602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lient mode Change-Id: I2d9e1c3ab65b648bc1ad321268394e0d15b1eb3f
|
Test build #79541 has finished for PR 18602 at commit
|
|
CC @vanzin @tgravescs would you please help to review? Thanks! |
|
I commented on the bug. |
|
Thanks @vanzin , based on the comment of JIRA, I will try another approach, so closing it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR propose a new configuration "spark.yarn.am.extraClassPath" to extend AM classpath in yarn client mode. The specific scenario is that we have custom
ServiceCredentialProviderwhich will be loaded in AM, and this provider requires its additional dependencies to be added in AM classpath.Using "spark.driver.extraClassPath" (the current code) is not so proper in yarn client mode and if dependency paths are different for driver and AM node, then it is impossible to use this configuration. So instead we add a new configuration to extend AM classpath in yarn client mode.
How was this patch tested?
UT added and manual verification on local cluster.