[SPARK-21376][YARN] Fix yarn client token expire issue when cleaning the staging files in long running scenario #18617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g token expire issue Change-Id: I851f829d38ab93a4caafb7ca029d34da76f92f76
|
Test build #79577 has finished for PR 18617 at commit
|
|
@tgravescs @vanzin can you please help to review, thanks! |
vanzin
reviewed
Jul 13, 2017
| def cleanupStagingDirInternal(): Unit = { | ||
| val stagingDirPath = new Path(appStagingBaseDir, getAppStagingDir(appId)) | ||
| try { | ||
| val preserveFiles = sparkConf.get(PRESERVE_STAGING_FILES) |
There was a problem hiding this comment.
You could do this check before even trying anything else in this method (just return early).
There was a problem hiding this comment.
Sure, I will change the code.
Change-Id: I1b61dd676a5344c8e69a3d7d5268aa343bd1bf75
|
Test build #79593 has finished for PR 18617 at commit
|
|
Merging to master. |
|
Hi, All. |
asfgit
pushed a commit
that referenced
this pull request
Jul 14, 2017
…the staging files in long running scenario ## What changes were proposed in this pull request? This issue happens in long running application with yarn cluster mode, because yarn#client doesn't sync token with AM, so it will always keep the initial token, this token may be expired in the long running scenario, so when yarn#client tries to clean up staging directory after application finished, it will use this expired token and meet token expire issue. ## How was this patch tested? Manual verification is secure cluster. Author: jerryshao <sshao@hortonworks.com> Closes #18617 from jerryshao/SPARK-21376. (cherry picked from commit cb8d5cc)
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
…the staging files in long running scenario ## What changes were proposed in this pull request? This issue happens in long running application with yarn cluster mode, because yarn#client doesn't sync token with AM, so it will always keep the initial token, this token may be expired in the long running scenario, so when yarn#client tries to clean up staging directory after application finished, it will use this expired token and meet token expire issue. ## How was this patch tested? Manual verification is secure cluster. Author: jerryshao <sshao@hortonworks.com> Closes apache#18617 from jerryshao/SPARK-21376. (cherry picked from commit cb8d5cc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This issue happens in long running application with yarn cluster mode, because yarn#client doesn't sync token with AM, so it will always keep the initial token, this token may be expired in the long running scenario, so when yarn#client tries to clean up staging directory after application finished, it will use this expired token and meet token expire issue.
How was this patch tested?
Manual verification is secure cluster.