Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-21340] Bring pyspark BinaryClassificationMetrics to parity with the Scala API #18622

Closed
wants to merge 1 commit into from

Conversation

mgaido91
Copy link
Contributor

What changes were proposed in this pull request?

Adding all the missing methods in the pyspark API for the BinaryClassificationMetrics, ie.:

  • thresholds
  • roc
  • pr
  • fMeasureByThreshold
  • precisionByThreshold
  • recallByThreshold

How was this patch tested?

Tested manually.

@mgaido91 mgaido91 changed the title [SPARK 21340] Bring pyspark BinaryClassificationMetrics to parity with the Scala API [SPARK-21340] Bring pyspark BinaryClassificationMetrics to parity with the Scala API Jul 13, 2017
@jakecharland
Copy link

+1 on getting this verified.

@srowen
Copy link
Member

srowen commented Aug 4, 2017

@jakecharland that's just an automated message asking if it's OK to test. I'll kick it off

@SparkQA
Copy link

SparkQA commented Aug 4, 2017

Test build #3879 has finished for PR 18622 at commit d953bac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mgaido91
Copy link
Contributor Author

mgaido91 commented Aug 15, 2017

@srowen any comment on this PR? Thanks.

@holdenk
Copy link
Contributor

holdenk commented Aug 18, 2017

So while we are trying to limit the changes in mllib, we are currently exposing BinaryClassificationMetrics in the ML models so this makes sense to expose.

@holdenk
Copy link
Contributor

holdenk commented Aug 18, 2017

Oh wait sorry I misread that code, it looks like we have this already wrapped behind in the Spark ML API.

Since we aren't actively working on the Spark MLlib APIs right now I probably don't see us merging this.

@mgaido91
Copy link
Contributor Author

Thank @holdenk, should I close this PR then?

@holdenk
Copy link
Contributor

holdenk commented Aug 19, 2017

That would be good yes. Let me know if you're interested take a look at the PySpark ML API since we're actively working on improving that and would be great to have more interested folks there as well :)

@mgaido91
Copy link
Contributor Author

Thanks! Might you please resolve the JIRA as "Won't Fix" then?
Yes, of course I am interested, thanks @holdenk, if I can help and contribute I am very happy!

@mgaido91 mgaido91 closed this Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants