[MINOR][REFACTORING] KeyValueGroupedDataset.mapGroupsWithState uses flatMapGroupsWithState #18642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…latMapGroupsWithState
|
Test build #79633 has finished for PR 18642 at commit
|
zsxwing
reviewed
Jul 20, 2017
| groupingAttributes, | ||
| dataAttributes, | ||
| OutputMode.Update, | ||
| isMapGroupsWithState = true, |
There was a problem hiding this comment.
This change is not correct. It will set isMapGroupsWithState to false. However, looks like we don't have a unit test covering this :(
|
Since the fix is not right, @jaceklaskowski Could you close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactored
KeyValueGroupedDataset.mapGroupsWithStateto useflatMapGroupsWithStateexplicitly (so it's clear that the former is almost the latter)./cc @zsxwing @tdas
How was this patch tested?
local build