Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-21522][core] Fix flakiness in LauncherServerSuite. #18727

Closed
wants to merge 2 commits into from

Conversation

vanzin
Copy link
Contributor

@vanzin vanzin commented Jul 24, 2017

Handle the case where the server closes the socket before the full message
has been written by the client.

Marcelo Vanzin added 2 commits July 24, 2017 13:21
Handle the case where the server closes the socket before the full message
has been written by the client.
@SparkQA
Copy link

SparkQA commented Jul 24, 2017

Test build #79915 has finished for PR 18727 at commit f53ebd4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 24, 2017

Test build #79916 has finished for PR 18727 at commit 1fcbf53.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented Jul 31, 2017

retest this please

@SparkQA
Copy link

SparkQA commented Jul 31, 2017

Test build #80083 has finished for PR 18727 at commit 1fcbf53.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented Jul 31, 2017

retest this please

@SparkQA
Copy link

SparkQA commented Jul 31, 2017

Test build #80092 has finished for PR 18727 at commit 1fcbf53.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented Aug 1, 2017

retest this please

@SparkQA
Copy link

SparkQA commented Aug 1, 2017

Test build #80102 has finished for PR 18727 at commit 1fcbf53.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

@jiangxb1987 jiangxb1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vanzin
Copy link
Contributor Author

vanzin commented Aug 1, 2017

Merging to master / 2.2 / 2.1 / 2.0.

asfgit pushed a commit that referenced this pull request Aug 1, 2017
Handle the case where the server closes the socket before the full message
has been written by the client.

Author: Marcelo Vanzin <vanzin@cloudera.com>

Closes #18727 from vanzin/SPARK-21522.

(cherry picked from commit b133501)
Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
asfgit pushed a commit that referenced this pull request Aug 1, 2017
Handle the case where the server closes the socket before the full message
has been written by the client.

Author: Marcelo Vanzin <vanzin@cloudera.com>

Closes #18727 from vanzin/SPARK-21522.

(cherry picked from commit b133501)
Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
@asfgit asfgit closed this in b133501 Aug 1, 2017
asfgit pushed a commit that referenced this pull request Aug 1, 2017
Handle the case where the server closes the socket before the full message
has been written by the client.

Author: Marcelo Vanzin <vanzin@cloudera.com>

Closes #18727 from vanzin/SPARK-21522.

(cherry picked from commit b133501)
Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
@vanzin vanzin deleted the SPARK-21522 branch August 7, 2017 20:09
MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
Handle the case where the server closes the socket before the full message
has been written by the client.

Author: Marcelo Vanzin <vanzin@cloudera.com>

Closes apache#18727 from vanzin/SPARK-21522.

(cherry picked from commit b133501)
Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants