Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-21597][SS]Fix a potential overflow issue in EventTimeStats #18803

Closed
wants to merge 1 commit into from
Closed

[SPARK-21597][SS]Fix a potential overflow issue in EventTimeStats #18803

wants to merge 1 commit into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Aug 1, 2017

What changes were proposed in this pull request?

This PR fixed a potential overflow issue in EventTimeStats.

How was this patch tested?

The new unit tests

@marmbrus
Copy link
Contributor

marmbrus commented Aug 1, 2017

LGTM

@SparkQA
Copy link

SparkQA commented Aug 2, 2017

Test build #80132 has finished for PR 18803 at commit 7252e2a.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class EventTimeStats(var max: Long, var min: Long, var avg: Double, var count: Long)

@zsxwing
Copy link
Member Author

zsxwing commented Aug 2, 2017

retest this please

@SparkQA
Copy link

SparkQA commented Aug 2, 2017

Test build #80139 has finished for PR 18803 at commit 7252e2a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class EventTimeStats(var max: Long, var min: Long, var avg: Double, var count: Long)

@zsxwing
Copy link
Member Author

zsxwing commented Aug 2, 2017

Thanks! Merging to master and 2.2.

asfgit pushed a commit that referenced this pull request Aug 2, 2017
@zsxwing
[SPARK-21597][SS] Fix a potential overflow issue in EventTimeStats
397f904 
## What changes were proposed in this pull request?

This PR fixed a potential overflow issue in EventTimeStats.

## How was this patch tested?

The new unit tests

Author: Shixiong Zhu <shixiong@databricks.com>

Closes #18803 from zsxwing/avg.

(cherry picked from commit 7f63e85)
Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
@asfgit asfgit closed this in 7f63e85 Aug 2, 2017
@zsxwing zsxwing deleted the avg branch August 2, 2017 18:09
MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
@zsxwing @MatthewRBruce
[SPARK-21597][SS] Fix a potential overflow issue in EventTimeStats
913565e 
## What changes were proposed in this pull request?

This PR fixed a potential overflow issue in EventTimeStats.

## How was this patch tested?

The new unit tests

Author: Shixiong Zhu <shixiong@databricks.com>

Closes apache#18803 from zsxwing/avg.

(cherry picked from commit 7f63e85)
Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@zsxwing @marmbrus @SparkQA @srowen