-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-21750][SQL] Use Arrow 0.6.0 #18974
Conversation
Test build #80795 has finished for PR 18974 at commit
|
Test build #80797 has finished for PR 18974 at commit
|
Test build #80799 has finished for PR 18974 at commit
|
ping @srowen @ueshin @BryanCutler |
1 similar comment
ping @srowen @ueshin @BryanCutler |
Thanks for this @kiszk. I was thinking we would need to do an upgrade for DecimalType support. I'm going to help out with that on the Arrow side, but it still might not be ready until 1 or 2 more releases. I'm not sure what the general Spark stance is on updating dependencies like Arrow, but I can say that I did test 0.6 myself and did not see anything that might cause issues. Maybe someone else can share the policies on upgrading? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
Since Apache Spark 2.3.0 is the debut of Apache Arrow in Spark, I think we had better to use the latest one.
According to #18459, I'm pining @holdenk and @cloud-fan , too. |
I agree with the usage of the latest one in each release. It would be good to periodically update a library if the library does not introduce drastic change (e.g. changing APIs) for ensuring stability for a longer period. |
I'm ok with it if arrow 0.6.0 doesn't introduce new dependencies. |
Do we need to upgrade pyarrow in Jenkins environment? |
as with @Rushing my primary concern with the upgrade here is the Jenkins interaction of when we eventually need to upgrade th Python side as well. It seems like we might not need to yet for 0.6.0 but I'm hesitant about having mixed versions since I believe that is explicitly not an arrow guarantee in general. |
Thank you for comments. I understand issues regarding Jenkins interaction in the Python side. I close this PR for now since the Python side is not ready for upgrading Arrow. |
Hi, All.
|
What changes were proposed in this pull request?
Update Arrow version to 0.6.0
Here is a release note.
How was this patch tested?
Existing tests