Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the number of attempting to restart receiver greater than 0,spark do nothing in 'else' #19142

Closed
wants to merge 1 commit into from

Conversation

liuxianjiao
Copy link

When the number of attempting to restart receiver greater than 0,spark do nothing in 'else'.So I think we should log trace to let users know why.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Sep 6, 2017

I don't think this is worthwhile.

@liuxianjiao
Copy link
Author

@srowen
Thanks for your reply!We can let users know the theory of the restart of receiver by this PR.To be honest,the 'else' was redundancy,so I improve it by logtrace. To say the least,if this PR is not worthwhile and the 'else' do nothing,can we remove it.

@jerryshao
Copy link
Contributor

I'm -1 on this PR. This PR actually fix nothing instead of adding one trace log, also usually user will not enable trace log, so this one line fix is not so helpful.

You can find many place in Spark where it has no "else" branch, are you going to fix them all?

@liuxianjiao
Copy link
Author

@jerryshao so,what's the meaning of these empty 'else'?

@jerryshao
Copy link
Contributor

NVM, I mean in the Spark code there're some intended empty "else" branch, are you going to add trace log to them all?

srowen added a commit to srowen/spark that referenced this pull request Sep 12, 2017
@srowen srowen mentioned this pull request Sep 12, 2017
@asfgit asfgit closed this in dd88fa3 Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants