[SPARK-21939][TEST] Use TimeLimits instead of Timeouts

[dongjoon-hyun]

What changes were proposed in this pull request?

Since ScalaTest 3.0.0, org.scalatest.concurrent.Timeouts is deprecated.
This PR replaces the deprecated one with org.scalatest.concurrent.TimeLimits.

-import org.scalatest.concurrent.Timeouts._
+import org.scalatest.concurrent.TimeLimits._

How was this patch tested?

Pass the existing test suites.

[dongjoon-hyun]

Thank you for review and approval!

[jerryshao]

LGTM, there's a typo in PR description, "Timeouts is deprecated." not "TimeLimits".

[dongjoon-hyun]

Thank you so much for review, @jerryshao ! I'll fix the typo.

[HyukjinKwon]

Looks stop ensures correct shutdown in BlockGeneratorSuite is dependent on interrupting - http://www.scalatest.org/release_notes/3.0.0:

If you were relying on the default behavior of interrupting a thread on the JVM in ScalaTest 2.2.x, you'll need to define an implicit val referring to a ThreadSignaler

ScalaTest looks they changed the default for good reasons but looks we should explicitly set ThreadSignaler to keep the previous behaviour more conservatively.

implicit val defaultSignaler: Signaler = ThreadSignaler

I just double checked this passes the pending tests and also checked scalatest/scalatest@bfa983b.

[SparkQA]

Test build #81485 has finished for PR 19150 at commit ab339b3.

• This patch fails from timeout after a configured wait of `250m`.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• class DriverSuite extends SparkFunSuite with TimeLimits
• class AsyncRDDActionsSuite extends SparkFunSuite with BeforeAndAfterAll with TimeLimits
• class DAGSchedulerSuite extends SparkFunSuite with LocalSparkContext with TimeLimits
• class EventLoopSuite extends SparkFunSuite with TimeLimits
• trait StreamTest extends QueryTest with SharedSQLContext with TimeLimits with BeforeAndAfterAll

[dongjoon-hyun]

Oh, I see. Thank you so much. I'll add that.

[dongjoon-hyun]

BlockGeneratorSuite and StreamTest is fixed and tested.

[SparkQA]

Test build #81494 has finished for PR 19150 at commit 678d1b2.

• This patch fails due to an unknown error code, -9.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

Retest this please.

[srowen]

Looks good. Yeah I didn't update everything when I did the scalatest update for 2.12 because the patch was so big already. Yes I also met the same Thread Signaler issue.

[dongjoon-hyun]

Thank you for review and approval, @srowen ! :)

[SparkQA]

Test build #81500 has finished for PR 19150 at commit 678d1b2.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #81501 has finished for PR 19150 at commit 678d1b2.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[jerryshao]

Merging to master, thanks @dongjoon-hyun .

[dongjoon-hyun]

Thank you for review and merging, @jerryshao ! Also, thank you for review and approving, @HyukjinKwon and @srowen .