Quote table names in JDBC queries #19192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MySQL table names sometimes need to be quoted. This should fix that, although I haven't tested. Also, four quotes in a row is not readable.
|
Without this PR change, can users add quotes in the JDBC option |
gatorsmile
reviewed
Sep 12, 2017
| @@ -100,7 +100,7 @@ abstract class JdbcDialect extends Serializable { | |||
| * @return The SQL query to use for checking the table. | |||
| */ | |||
| def getTableExistsQuery(table: String): String = { | |||
| s"SELECT * FROM $table WHERE 1=0" | |||
| s"SELECT * FROM ${quoteIdentifier(table)} WHERE 1=0" | |||
There was a problem hiding this comment.
This is a behavior change. After we quote the names, the table names become case sensitive in most RDBMS. We need at least a JDBC option to control it.
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MySQL table names sometimes need to be quoted. This should fix that, although I haven't tested (I really don't want to go through the build and everything).
Also, four quotes in a row is not readable.