Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get default Locale #19200

Closed
wants to merge 1 commit into from
Closed

Get default Locale #19200

wants to merge 1 commit into from

Conversation

Gschiavon
Copy link
Contributor

What changes were proposed in this pull request?

Get default Locale in UtilsSuite.scala in order to make it work with different Locales than US.

How was this patch tested?

Running UtilsSuite.scala

Please review http://spark.apache.org/contributing.html before opening a pull request.

@Gschiavon Gschiavon changed the title Set default Locale Get default Locale Sep 12, 2017
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Sep 12, 2017

No, because the project is purposely not locale sensitive at this level.

@Gschiavon
Copy link
Contributor Author

As far as I saw there are other test cases that set default locale to US. This case is not passing when your jvm default locale value differs from "US".

@srowen
Copy link
Member

srowen commented Sep 12, 2017

Ah, the problem is the reverse really, but there is a problem. "...".format(...) is locale-sensitive in Scala, and this is a place where that matters. The Utils method needs to change to use formalLocal with Locale.US. Open a JIRA for it, and close this and reopen vs master with that fix.

@Gschiavon
Copy link
Contributor Author

Ok, I got it. I will do that then.
Thanks.

@Gschiavon Gschiavon closed this Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants