[SPARK-22040] Add current_date function with timezone id #19261
Conversation
|
Can one of the admins verify this patch? |
| * @group datetime_funcs | ||
| * @since 2.3.0 | ||
| */ | ||
| def current_date(timeZone: String): Column = withExpr { CurrentDate(Option(timeZone)) } |
There was a problem hiding this comment.
What if someone pass a null as value? Option is safer in this case...
| @@ -2508,6 +2508,14 @@ object functions { | |||
| def current_date(): Column = withExpr { CurrentDate() } | |||
|
|
|||
| /** | |||
| * Returns the current date in the given timezone as a date column. | |||
There was a problem hiding this comment.
this is consistent with all the other functions in this file.
| @@ -793,12 +793,12 @@ def ntile(n): | |||
| # ---------------------- Date/Timestamp functions ------------------------------ | |||
|
|
|||
| @since(1.5) | |||
| def current_date(): | |||
| def current_date(timeZone=None): | |||
There was a problem hiding this comment.
Would the change beg a different @since? It's no longer true that it existed since(1.5), is it? Just asking...no idea how it really should be.
There was a problem hiding this comment.
Honestly I have no idea too.. Do you know who can we ask to? Thanks.
|
Any other database allows users to do it? |
|
@gatorsmile Dunno, but the logical operator does. |
|
What does this even mean? |
|
I think we should not do it, because no DB vendor does it. |
|
@rxin @gatorsmile Let me ask you a very similar question then, why does I don't mind not having the change, but am curious what is the reason for the "mismatch"? |
|
When we introduce the external APIs, we have to be very careful. Regarding the usage of |
|
OK I feel convinced that you feel convinced Spark SQL should not offer this as part of the public API. Thanks for being with me for so long and patient to explain the things. Thanks. @mgaido91 What do you think about closing this PR and the corresponding JIRA issue (to record your commitment on it)? Thanks. |
What changes were proposed in this pull request?
Add current_date function with timezone id.
How was this patch tested?
Manual test on spark-shell and pyspark.