Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][ML]Updated english.txt word ordering #19315

Closed
wants to merge 1 commit into from
Closed

[MINOR][ML]Updated english.txt word ordering #19315

wants to merge 1 commit into from

Conversation

animenon
Copy link
Contributor

Ordered alphabetically, for better readability.

What changes were proposed in this pull request?

Alphabetical ordering of the stop words.

Ordered alphabetically, for better readability.
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@jerryshao
Copy link
Contributor

@animenon can you please fix the PR title like what other PR did. Also is this only for better readability or do you fix any other issue? IMO, I found that previous txt is more readable than your change, since they're ordered by different kind.

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ordering is unimportant. It also came from an external source so easier to leave it like the original. Not worthwhile here.

@animenon animenon changed the title Updated english.txt word ordering [MINOR][ML]Updated english.txt word ordering Sep 22, 2017
@animenon
Copy link
Contributor Author

animenon commented Sep 22, 2017

@jerryshao done. And browsing through the list is made easier with this ordering.

@srowen I wanted to search if few of the words were on the list and found it to be rather tough to find. It would be much easier to browse through this way. And ya I saw the old thread, source is NLTK data.

@srowen
Copy link
Member

srowen commented Sep 22, 2017

Just ctrl-F and find?

@animenon
Copy link
Contributor Author

Right, but if you want to check a few things together like "who", "who's", "why", "when", etc you will have to do many finds; but in an ordered document it would be much easier.

@srowen srowen mentioned this pull request Sep 26, 2017
@asfgit asfgit closed this in ceaec93 Sep 27, 2017
@animenon animenon deleted the patch-1 branch December 18, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants