[SPARK-22135] [MESOS] metrics in spark-dispatcher not being registered properly #19358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test. |
|
Would you please add a [MESOS]tag in your PR title, like other PR did. Thanks. |
|
Test build #82218 has finished for PR 19358 at commit
|
srowen
reviewed
Sep 27, 2017
| override def sourceName: String = "mesos_cluster" | ||
| override def metricRegistry: MetricRegistry = new MetricRegistry() | ||
| override def metricRegistry: MetricRegistry = registry |
There was a problem hiding this comment.
Actually, just change both of these to override val ...
pmackles
changed the title
|
thanks for the quick review @srowen and @jerryshao - both requested changes committed |
|
Test build #82235 has finished for PR 19358 at commit
|
|
LGTM. |
|
Merging to master and branch 2.2. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Sep 28, 2017
… properly ## What changes were proposed in this pull request? Fix a trivial bug with how metrics are registered in the mesos dispatcher. Bug resulted in creating a new registry each time the metricRegistry() method was called. ## How was this patch tested? Verified manually on local mesos setup Author: Paul Mackles <pmackles@adobe.com> Closes #19358 from pmackles/SPARK-22135. (cherry picked from commit f20be4d) Signed-off-by: jerryshao <sshao@hortonworks.com>
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
… properly ## What changes were proposed in this pull request? Fix a trivial bug with how metrics are registered in the mesos dispatcher. Bug resulted in creating a new registry each time the metricRegistry() method was called. ## How was this patch tested? Verified manually on local mesos setup Author: Paul Mackles <pmackles@adobe.com> Closes apache#19358 from pmackles/SPARK-22135. (cherry picked from commit f20be4d) Signed-off-by: jerryshao <sshao@hortonworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix a trivial bug with how metrics are registered in the mesos dispatcher. Bug resulted in creating a new registry each time the metricRegistry() method was called.
How was this patch tested?
Verified manually on local mesos setup