[SPARK-22214][SQL] Refactor the list hive partitions code #19444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangxb1987
commented
Oct 6, 2017
| @@ -638,12 +638,14 @@ private[hive] class HiveClientImpl( | |||
| table: CatalogTable, | |||
| spec: Option[TablePartitionSpec]): Seq[CatalogTablePartition] = withHiveState { | |||
| val hiveTable = toHiveTable(table, Some(userName)) | |||
| val parts = spec match { | |||
| case None => shim.getAllPartitions(client, hiveTable).map(fromHivePartition) | |||
There was a problem hiding this comment.
After this change, HiveShim.getAllPartitions is only used to support HiveShim.getPartitionsByFilter for hive 0.12, we may consider completely remove the method in the future.
|
Test build #82509 has finished for PR 19444 at commit
|
gatorsmile
reviewed
Oct 6, 2017
| @@ -638,12 +638,14 @@ private[hive] class HiveClientImpl( | |||
| table: CatalogTable, | |||
| spec: Option[TablePartitionSpec]): Seq[CatalogTablePartition] = withHiveState { | |||
| val hiveTable = toHiveTable(table, Some(userName)) | |||
| val parts = spec match { | |||
| case None => shim.getAllPartitions(client, hiveTable).map(fromHivePartition) | |||
| val partialPartSpec = spec match { | |||
|
LGTM except a minor comment. |
|
LGTM |
|
Test build #82519 has finished for PR 19444 at commit
|
|
Thanks! Merged to master. |
cloud-fan
reviewed
Oct 9, 2017
| /** | ||
| * Initialize an empty spec. | ||
| */ | ||
| lazy val emptyTablePartitionSpec: TablePartitionSpec = Map.empty[String, String] |
There was a problem hiding this comment.
Map.empty is already an object, I think we can jus inline it
There was a problem hiding this comment.
We wanted to refer the val emptyTablePartitionSpec as TablePartitionSpec, not Map[String, String], though they are equal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR we make a few changes to the list hive partitions code, to make the code more extensible.
The following changes are made:
HiveClientImpl.getPartitions(), callclient.getPartitionsinstead ofshim.getAllPartitionswhenspecis empty;HiveTableScanExec, previously we always calllistPartitionsByFilterif the configmetastorePartitionPruningis enabled, but actually, we'd better calllistPartitionsifpartitionPruningPredis empty;HiveTableScanExec.How was this patch tested?
Tested by existing test cases since this is code refactor, no regression or behavior change is expected.