[SPARK-21165][SQL] FileFormatWriter should handle mismatched attribute ids between logical and physical plan #19483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gatorsmile |
|
Test build #82683 has finished for PR 19483 at commit
|
|
Test build #82685 has finished for PR 19483 at commit
|
cloud-fan
changed the title
|
It sounds like we are facing various issues because we are using the analyzed plan. Is that possible we just add an extra Project using the analyzed plan's output at the end of optimizer? |
|
I'll refactor it later, to use |
The hive bucketing PR does that : #19001 I can isolate that piece and put out a PR |
|
that will be great, thanks @tejasapatil ! |
|
Test build #82712 has finished for PR 19483 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Oct 13, 2017
…ry schema ## What changes were proposed in this pull request? #18386 fixes SPARK-21165 but breaks SPARK-22252. This PR reverts #18386 and picks the patch from #19483 to fix SPARK-21165. ## How was this patch tested? new regression test Author: Wenchen Fan <wenchen@databricks.com> Closes #19484 from cloud-fan/bug.
|
thanks for the review, merging to master! |
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
…ry schema ## What changes were proposed in this pull request? apache#18386 fixes SPARK-21165 but breaks SPARK-22252. This PR reverts apache#18386 and picks the patch from apache#19483 to fix SPARK-21165. ## How was this patch tested? new regression test Author: Wenchen Fan <wenchen@databricks.com> Closes apache#19484 from cloud-fan/bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Due to optimizer removing some unnecessary aliases, the logical and physical plan may have different output attribute ids. FileFormatWriter should handle this when creating the physical sort node.
How was this patch tested?
new regression test.