Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo #19613

Closed
wants to merge 1 commit into from
Closed

Fixed a typo #19613

wants to merge 1 commit into from

Conversation

ganeshchand
Copy link
Contributor

ready to serialized => ready to be serialized

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please review http://spark.apache.org/contributing.html before opening a pull request.

ready to serialized => ready to be serialized
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, but please take the chance to look for more typos in one go.

@jmchung
Copy link
Contributor

jmchung commented Oct 31, 2017

Hi @ganeshchand , could you also fix the typo in JdbcUtils.scala? Thanks!
#L459 underling => underlying

@srowen
Copy link
Member

srowen commented Oct 31, 2017

Or in UnsafeArrayData, corrresponding -> corresponding
If you just run a spell check of comments in an IDE, I'm sure a quick pass would reveal a lot of little typos. The more you are willing to fix in one pass, the better.

@ganeshchand
Copy link
Contributor Author

@srowen, @jmchung - I came across the typo while reading the source for this specific class. Yeah, I agree with your suggestion on running spell checks and fix as much in one pass. I'll submit another PR.

@srowen
Copy link
Member

srowen commented Nov 1, 2017

Just add to this one. Any additional typos you can pick up in a quick pass are helpful

@srowen
Copy link
Member

srowen commented Nov 4, 2017

Ping @ganeshchand to address whatever typos have been found to date or close

@srowen
Copy link
Member

srowen commented Nov 7, 2017

Close this if you're not going to update @ganeshchand

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

srowen added a commit to srowen/spark that referenced this pull request Dec 31, 2017
@srowen srowen mentioned this pull request Dec 31, 2017
@asfgit asfgit closed this in f5b7714 Jan 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants