Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-19759][ML] not using blas in ALSModel.predict for optimization #19685

Closed
wants to merge 2 commits into from
Closed

[SPARK-19759][ML] not using blas in ALSModel.predict for optimization #19685

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b0add6
[SPARK-19759][ML] not using blas in ALSModel.predict for optimization
mgaido91 Nov 7, 2017
4867345
convert for to while loop
mgaido91 Nov 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
View file
Open in desktop
Expand Up @@ -289,9 +289,11 @@ class ALSModel private[ml] (

private val predict = udf { (featuresA: Seq[Float], featuresB: Seq[Float]) =>
if (featuresA != null && featuresB != null) {
// TODO(SPARK-19759): try dot-producting on Seqs or another non-converted type for
// potential optimization.
blas.sdot(rank, featuresA.toArray, 1, featuresB.toArray, 1)
var dotProduct = 0.0f
for(i <- 0 until rank) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use while instead of for

dotProduct += featuresA(i) * featuresB(i)
}
dotProduct
} else {
Float.NaN
}
Expand Down