[SPARK-3078][MLLIB] Make LRWithLBFGS API consistent with others #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA tests have started for PR 1973 at commit
|
|
QA tests have finished for PR 1973 at commit
|
|
Jenkins, retest this please. |
|
QA tests have started for PR 1973 at commit
|
| def setMaxNumIterations(iters: Int): this.type = { | ||
| this.setNumCorrections(iters) |
There was a problem hiding this comment.
Should it be
this. setNumIterations(iters)
|
QA tests have finished for PR 1973 at commit
|
|
QA tests have started for PR 1973 at commit
|
|
QA tests have started for PR 1973 at commit
|
|
QA tests have finished for PR 1973 at commit
|
|
QA tests have finished for PR 1973 at commit
|
|
LGTM. Merged into both master and branch-1.1. Thanks!! |
asfgit
pushed a commit
that referenced
this pull request
Aug 16, 2014
Should ask users to set parameters through the optimizer. dbtsai Author: Xiangrui Meng <meng@databricks.com> Closes #1973 from mengxr/lr-lbfgs and squashes the following commits: e3efbb1 [Xiangrui Meng] fix tests 21b3579 [Xiangrui Meng] fix method name 641eea4 [Xiangrui Meng] Merge remote-tracking branch 'apache/master' into lr-lbfgs 456ab7c [Xiangrui Meng] update LRWithLBFGS (cherry picked from commit 5d25c0b) Signed-off-by: Xiangrui Meng <meng@databricks.com>
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
Should ask users to set parameters through the optimizer. dbtsai Author: Xiangrui Meng <meng@databricks.com> Closes apache#1973 from mengxr/lr-lbfgs and squashes the following commits: e3efbb1 [Xiangrui Meng] fix tests 21b3579 [Xiangrui Meng] fix method name 641eea4 [Xiangrui Meng] Merge remote-tracking branch 'apache/master' into lr-lbfgs 456ab7c [Xiangrui Meng] update LRWithLBFGS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should ask users to set parameters through the optimizer. @dbtsai