-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-22515] [SQL] Estimation relation size based on numRows * rowSize #19743
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,7 +41,35 @@ import org.apache.spark.sql.types._ | |
|
||
|
||
class StatisticsSuite extends StatisticsCollectionTestBase with TestHiveSingleton { | ||
test("Hive serde tables should fallback to HDFS for size estimation") { | ||
|
||
test("size estimation for relations based on row size * number of rows") { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: |
||
val dsTbl = "rel_est_ds_table" | ||
val hiveTbl = "rel_est_hive_table" | ||
withTable(dsTbl, hiveTbl) { | ||
spark.range(1000L).write.format("parquet").saveAsTable(dsTbl) | ||
sql(s"CREATE TABLE $hiveTbl STORED AS parquet AS SELECT * FROM $dsTbl") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: |
||
|
||
Seq(dsTbl, hiveTbl).foreach { tbl => | ||
sql(s"ANALYZE TABLE $tbl COMPUTE STATISTICS") | ||
val catalogStats = getCatalogStatistics(tbl) | ||
withSQLConf(SQLConf.CBO_ENABLED.key -> "false") { | ||
val relationStats = spark.table(tbl).queryExecution.optimizedPlan.stats | ||
assert(relationStats.sizeInBytes == catalogStats.sizeInBytes) | ||
assert(relationStats.rowCount.isEmpty) | ||
} | ||
spark.sessionState.catalog.refreshTable(TableIdentifier(tbl)) | ||
withSQLConf(SQLConf.CBO_ENABLED.key -> "true") { | ||
val relationStats = spark.table(tbl).queryExecution.optimizedPlan.stats | ||
// Due to compression in parquet files, in this test, file size is smaller than | ||
// in-memory size. | ||
assert(catalogStats.sizeInBytes < relationStats.sizeInBytes) | ||
assert(catalogStats.rowCount == relationStats.rowCount) | ||
} | ||
} | ||
} | ||
} | ||
|
||
test("Hive serde tables should fallback to HDFS for size estimation") { | ||
withSQLConf(SQLConf.ENABLE_FALL_BACK_TO_HDFS_FOR_STATS.key -> "true") { | ||
withTable("csv_table") { | ||
withTempDir { tempDir => | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now we need to update the comment:
when CBP is disabled or the table doesn't have statistics