Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-22540][SQL] Ensure HighlyCompressedMapStatus calculates correct avgSize #19765

Closed
wants to merge 2 commits into from

Conversation

yucai
Copy link
Contributor

@yucai yucai commented Nov 16, 2017

What changes were proposed in this pull request?

Ensure HighlyCompressedMapStatus calculates correct avgSize

How was this patch tested?

New unit test added.

@HyukjinKwon
Copy link
Member

ok to test

Copy link
Contributor

@jiangxb1987 jiangxb1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only one nit

@@ -98,6 +98,28 @@ class MapStatusSuite extends SparkFunSuite {
}
}

test("[SPARK-22540]: HighlyCompressedMapStatus's avgSize is incorrect") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: test("SPARK-22540: ensure HighlyCompressedMapStatus calculates correct avgSize")

@SparkQA
Copy link

SparkQA commented Nov 16, 2017

Test build #83938 has finished for PR 19765 at commit af7b94d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 16, 2017

Test build #83940 has finished for PR 19765 at commit 23282da.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yucai yucai changed the title [SPARK-22540][SQL] Fix incorrect avgSize in HighlyCompressedMapStatus [SPARK-22540][SQL] Ensure HighlyCompressedMapStatus calculates correct avgSize Nov 16, 2017
asfgit pushed a commit that referenced this pull request Nov 17, 2017
…t avgSize

## What changes were proposed in this pull request?

Ensure HighlyCompressedMapStatus calculates correct avgSize

## How was this patch tested?

New unit test added.

Author: yucai <yucai.yu@intel.com>

Closes #19765 from yucai/avgsize.

(cherry picked from commit d00b55d)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen
Copy link
Member

srowen commented Nov 17, 2017

Merged to master/2.2

@asfgit asfgit closed this in d00b55d Nov 17, 2017
MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
…t avgSize

## What changes were proposed in this pull request?

Ensure HighlyCompressedMapStatus calculates correct avgSize

## How was this patch tested?

New unit test added.

Author: yucai <yucai.yu@intel.com>

Closes apache#19765 from yucai/avgsize.

(cherry picked from commit d00b55d)
Signed-off-by: Sean Owen <sowen@cloudera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants