[SPARK-22694][SQL] Like and RLike should not use global variables #19897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #84483 has finished for PR 19897 at commit
|
|
@cloud-fan @kiszk @viirya may you please review this? Thanks |
cloud-fan
reviewed
Dec 6, 2017
| @@ -119,33 +119,34 @@ case class Like(left: Expression, right: Expression) extends StringRegexExpressi | |||
| if (rVal != null) { | |||
| val regexStr = | |||
| StringEscapeUtils.escapeJava(escape(rVal.asInstanceOf[UTF8String].toString())) | |||
| ctx.addMutableState(patternClass, pattern, | |||
| s"""$pattern = ${patternClass}.compile("$regexStr");""") | |||
There was a problem hiding this comment.
This can avoid compiling the regex every time.
There was a problem hiding this comment.
but we are adding a new one every time, so we are compiling it every time. Am I wrong?
There was a problem hiding this comment.
no, the code generating logic runs only once, the generated code runs many times, for each input row.
There was a problem hiding this comment.
Sorry, you are right, my bad mistake. I am closing this PR immediately, sorry.
There was a problem hiding this comment.
ah that's ok, Spark's codegen framework is pretty hard to understand, it takes time to get familiar with it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Like and RLike are using a global variable which is not needed. This can generate some unneeded entries in the constant pool.
The PR removes the unnecessary mutable states and makes them local variables.
How was this patch tested?
added UTs