Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-20728][SQL][FOLLOWUP] Use an actionable exception message #19903

Closed
wants to merge 4 commits into from
Closed

[SPARK-20728][SQL][FOLLOWUP] Use an actionable exception message #19903

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6cdde7
[SPARK-20728][SQL][FOLLOWUP] Use a actionable exception message
dongjoon-hyun Dec 6, 2017
ba1e3ae
Address comments
dongjoon-hyun Dec 6, 2017
d7d268d
Address comments
dongjoon-hyun Dec 6, 2017
9809af8
Remove invalid condition
dongjoon-hyun Dec 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,8 @@ object DataSource extends Logging {
provider1.startsWith("org.apache.spark.sql.hive.orc")) {
throw new AnalysisException(
"Hive-based ORC data source must be used with Hive support enabled. " +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hive built-in ORC data source must be used with Hive support enabled.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

"Please use native ORC data source instead")
"Please use native ORC data source instead by setting 'spark.sql.orc.impl' " +
"configuration to 'native'")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the native ORC data source by setting 'spark.sql.orc.impl' to 'native'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

} else if (provider1.toLowerCase(Locale.ROOT) == "avro" ||
provider1 == "com.databricks.spark.avro") {
throw new AnalysisException(
Expand Down