-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-22756] [Build] [SparkR] Run SparkR tests if hive_thriftserver module has code changes #19944
Conversation
@@ -481,7 +481,7 @@ def __hash__(self): | |||
|
|||
sparkr = Module( | |||
name="sparkr", | |||
dependencies=[hive, mllib], | |||
dependencies=[hive, mllib, hive_thriftserver], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since SparkR already depends on hive, this PR just adds the dependence on hive_thriftserver
Test build #84735 has finished for PR 19944 at commit
|
Test build #84736 has finished for PR 19944 at commit
|
cc @felixcheung Very weird... I can reproduce it in my local environment. Could you take a look at why SparkR failed?
|
Hm, @gatorsmile. BTW, do you maybe know how CRAN check fails by the changes in the thrift server? I was just double checking for sure but it sounds orthogonal to me now. The test failure above seems due to missing package |
Yes this seems unrelated - it’s just saying you need the package e1071 to run the test.
Anyone know why SparkR tests are failing all of a sudden? There is nothing in the log file like this one
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84726/console
|
To clarify it looks like SparkR test is failing in other PRs.
|
Yup and it looks passing fine back now (roughly just a couple(?) of hours ago). Seems the problem was this one(?)
|
retest this please |
Test build #84768 has finished for PR 19944 at commit
|
I am afraid that thriftserver PR could break it, because it writes to the log if |
How about merging this PR first? and let @zouchenjun resubmit the PR? |
What changes were proposed in this pull request?
The recent PR change in
hive_thriftserver
caused the test failure in CRAN requirements. To some extends,SparkR
module also depends onhive_thriftserver
module which could output some log files, so we should runSparkR
tests if thehive_thriftserver
module has code changes.How was this patch tested?
N/A