[SPARK-22762][TEST] Basic tests for IfCoercion and CaseWhenCoercion #19949
Conversation
|
Out of curiosity, does anyone know if we are okay with elapsed time now? |
|
To be clear, I am not against this change. I am asking this because simply I remember I was working on another stuff related with this test but the elapsed time concern was raised before. I see a bunch of tests being added here and I think it's a valid concern. I simply just wonder the elapsed time (wouldn't be difficult to check) and roughly how many tests you plan to add. |
|
Test build #84757 has finished for PR 19949 at commit
|
|
Ah, I just checked the log and seems quite short. I take my words back. I am fine. |
|
|
||
| CREATE TEMPORARY VIEW t AS SELECT 1; | ||
|
|
||
| SELECT CASE WHEN true THEN cast(1 as tinyint) ELSE cast(2 as tinyint) END FROM t; |
There was a problem hiding this comment.
Just want to confirm whether these queries you added can be executed in Hive?
There was a problem hiding this comment.
@gatorsmile Two questions:
- Hive doesn't have the
shorttype, so can we remove theshorttype here? - Hive can't execute
CREATE TEMPORARY VIEW ..., but can executorCREATE TEMPORARY TABLE ..., Do we add this feature to spark?
There was a problem hiding this comment.
In the future, we might do it for supporting the actual TEMP table.
Yeah, please get rid of short.
|
LGTM except the comment about |
|
Test build #84942 has finished for PR 19949 at commit
|
|
retest this please |
|
Test build #84948 has finished for PR 19949 at commit
|
|
Thanks! Merged to master. |
What changes were proposed in this pull request?
Basic tests for IfCoercion and CaseWhenCoercion
How was this patch tested?
N/A