[SPARK-22769][CORE] When driver stopping, there is errors: Could not find CoarseGrainedScheduler and RpcEnv already stopped #19968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You already had another PR open for the same issue, which was an exact duplicate of another PR, for another issue that is a duplicate. Please clean it up into one issue -- SPAKR-22769 |
KaiXinXiaoLei
changed the title
KaiXinXiaoLei
changed the title
|
Test build #84855 has finished for PR 19968 at commit
|
|
Test build #84856 has finished for PR 19968 at commit
|
|
Test build #84867 has finished for PR 19968 at commit
|
zsxwing
reviewed
Dec 18, 2017
| @@ -100,6 +102,7 @@ private[netty] class Dispatcher(nettyEnv: NettyRpcEnv, numUsableCores: Int) exte | |||
| return | |||
| } | |||
| unregisterRpcEndpoint(rpcEndpointRef.name) | |||
| endpointsIsStopped.putIfAbsent(rpcEndpointRef.name, true) | |||
There was a problem hiding this comment.
this will be a memory leak. Spark may create some temp RpcEndpoints. You can make postMessage return Some(RpcEndpointNotFoundException) and ignore it.
|
Ping @KaiXinXiaoLei to update or close |
|
@srowen ok ,i will update, thanks |
|
ping @KaiXinXiaoLei are you still working on this? |
|
Now this problem， i don't work. Now i close it . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When driver stopping, there is a error:
Because the endpoint of CoarseGrainedScheduler is stopped, this error is not problem, so i think this error should not be printed.
And there is another error:
I think the log level should be warning, not error.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.