Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-22836][ui] Show driver logs in UI when available. #20038

Closed
wants to merge 1 commit into from
Closed

[SPARK-22836][ui] Show driver logs in UI when available. #20038

wants to merge 1 commit into from

Conversation

vanzin
Copy link
Contributor

@vanzin vanzin commented Dec 20, 2017

Port code from the old executors listener to the new one, so that
the driver logs present in the application start event are kept.

[SPARK-22836][ui] Show driver logs in UI when available.
52641db 
Port code from the old executors listener to the new one, so that
the driver logs present in the application start event are kept.
@SparkQA
Copy link

SparkQA commented Dec 20, 2017

Test build #85201 has finished for PR 20038 at commit 52641db.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please

@SparkQA
Copy link

SparkQA commented Dec 21, 2017

Test build #85211 has finished for PR 20038 at commit 52641db.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

gengliangwang
gengliangwang approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@gengliangwang gengliangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Dec 21, 2017

Test build #85259 has finished for PR 20038 at commit 52641db.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin vanzin mentioned this pull request Dec 21, 2017
Closed
@squito
Copy link
Contributor

squito commented Dec 21, 2017

lgtm

@asfgit asfgit closed this in 9c21ece Dec 28, 2017
@squito
Copy link
Contributor

squito commented Dec 28, 2017

merged to master

@vanzin vanzin deleted the SPARK-22836 branch January 5, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengliangwang gengliangwang gengliangwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@vanzin @SparkQA @dongjoon-hyun @HyukjinKwon @squito @gengliangwang