Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-17088][hive] Fix 'sharesHadoopClasses' option when creating client. #20169

Closed
wants to merge 1 commit into from
Closed

[SPARK-17088][hive] Fix 'sharesHadoopClasses' option when creating client. #20169

wants to merge 1 commit into from

Commits on Jan 5, 2018

  1. [SPARK-17088][hive] Fix 'sharesHadoopClasses' option when creating cl… 

    …ient.

Because the call to the constructor of HiveClientImpl crosses class loader
boundaries, different versions of the same class (Configuration) in this
case were loaded, and that caused a runtime error when instantiating the
client. By using a safer type in the signature of the constructor, it's
possible to avoid the problem.

I considered removing 'sharesHadoopClasses', but it may still be desired
(even though there are 0 users of it since it was not working). When Spark
starts to support Hadoop 3, it may be necessary to use that option to
load clients for older Hive metastore versions that don't know about
Hadoop 3.

Tested with added unit test.
    Marcelo Vanzin committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    668fcba View commit details
    Browse the repository at this point in the history