Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-11630] [core] ClosureCleaner moved from warning to debug #20337

Closed
wants to merge 12 commits into from
Closed

[SPARK-11630] [core] ClosureCleaner moved from warning to debug #20337

wants to merge 12 commits into from

Conversation

rekhajoshm
Copy link
Contributor

What changes were proposed in this pull request?

ClosureCleaner moved from warning to debug

How was this patch tested?

Existing tests

@rekhajoshm
Merge pull request #1 from apache/master
e3677c9 
Pulling functionality from apache spark
@rekhajoshm
Merge pull request #2 from apache/master
106fd8e 
pull latest from apache spark
@rekhajoshm
Merge pull request #3 from apache/master
0be142d 
Pulling functionality from apache spark
@rekhajoshm
Merge pull request #4 from apache/master
6c6ee12 
Pulling functionality from apache spark
@rekhajoshm
Merge pull request #5 from apache/master
b123c60 
pull request from apache/master
@rekhajoshm
Merge pull request #6 from apache/master
c73c32a 
pull latest from apache spark
@rekhajoshm
Merge pull request #8 from apache/master
7dbf732 
pull latest from apache spark
@rekhajoshm
Merge pull request #9 from apache/master
5e9d718 
Pull apache spark
@rekhajoshm
Merge pull request #10 from apache/master
63d99b3 
pull latest apache spark
@rekhajoshm
Merge pull request #11 from apache/master
a7fc787 
Apache spark pull latest
@rekhajoshm
[SPARK-11630] [core] ClosureCleaner removed warning
e978154
@srowen
Copy link
Member

srowen commented Jan 21, 2018

I think that's fine, especially as Scala 2.12 and its different implementation of some closures triggers this a lot. You could use string interpolation while here.

@rekhajoshm
Copy link
Contributor Author

thanks @srowen done.

@SparkQA
Copy link

SparkQA commented Jan 21, 2018

Test build #86421 has finished for PR 20337 at commit e978154.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 21, 2018

Test build #86422 has finished for PR 20337 at commit 4de2bc6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jan 22, 2018

Merged to master

@asfgit asfgit closed this in 4327ccf Jan 22, 2018
@rekhajoshm rekhajoshm deleted the SPARK-11630-1 branch June 21, 2018 06:11
@rekhajoshm rekhajoshm restored the SPARK-11630-1 branch June 21, 2018 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rekhajoshm @srowen @SparkQA