[MINOR] [SQL] [TEST] Test case cleanups for recent PRs #20341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
commented
Jan 21, 2018
| sql(s"DROP TEMPORARY FUNCTION IF EXISTS hive_max") | ||
| try { | ||
| sql(s"DROP TEMPORARY FUNCTION IF EXISTS mock") | ||
| sql(s"DROP TEMPORARY FUNCTION IF EXISTS hive_max") |
There was a problem hiding this comment.
Actually, these drop functions are unnecessary. However, it sounds also fine to keep them because we should clean up the local objects after usage.
gatorsmile
commented
Jan 21, 2018
| @@ -492,8 +492,7 @@ private[hive] class TestHiveSparkSession( | |||
| protected val originalUDFs: JavaSet[String] = FunctionRegistry.getFunctionNames | |||
|
|
|||
| /** | |||
| * Resets the test instance by deleting any tables that have been created. | |||
| * TODO: also clear out UDFs, views, etc. | |||
There was a problem hiding this comment.
These TODOs have been addressed.
gatorsmile
commented
Jan 21, 2018
| val dfOne = df.select(lit(1).as("a")) | ||
| val dfTwo = spark.range(10).select(lit(2).as("b")) | ||
| dfOne.join(dfTwo, $"a" === $"b", "left").queryExecution.optimizedPlan | ||
| } |
|
cc @cloud-fan |
gatorsmile
changed the title
|
LGTM |
|
Test build #86440 has finished for PR 20341 at commit
|
dongjoon-hyun
approved these changes
Jan 22, 2018
gatorsmile
changed the title
asfgit
pushed a commit
that referenced
this pull request
Jan 22, 2018
## What changes were proposed in this pull request? Revert the unneeded test case changes we made in SPARK-23000 Also fixes the test suites that do not call `super.afterAll()` in the local `afterAll`. The `afterAll()` of `TestHiveSingleton` actually reset the environments. ## How was this patch tested? N/A Author: gatorsmile <gatorsmile@gmail.com> Closes #20341 from gatorsmile/testRelated. (cherry picked from commit 896e45a) Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Revert the unneeded test case changes we made in SPARK-23000
Also fixes the test suites that do not call
super.afterAll()in the localafterAll. TheafterAll()ofTestHiveSingletonactually reset the environments.How was this patch tested?
N/A