[MINOR] Typo fixes #20344
Closed
[MINOR] Typo fixes #20344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
reviewed
Jan 21, 2018
| @@ -1222,7 +1222,7 @@ class Analyzer( | |||
| wf | |||
| } | |||
| // We get an aggregate function, we need to wrap it in an AggregateExpression. | |||
| case agg: AggregateFunction => AggregateExpression(agg, Complete, isDistinct) | |||
| case agg: AggregateFunction => agg.toAggregateExpression(isDistinct) | |||
There was a problem hiding this comment.
This doesn't look like a typo fix
| @@ -199,7 +199,7 @@ case class UnresolvedGenerator(name: FunctionIdentifier, children: Seq[Expressio | |||
| override def prettyName: String = name.unquotedString | |||
| override def toString: String = s"'$name(${children.mkString(", ")})" | |||
|
|
|||
| override def eval(input: InternalRow = null): TraversableOnce[InternalRow] = | |||
| override def eval(input: InternalRow = EmptyRow): TraversableOnce[InternalRow] = | |||
There was a problem hiding this comment.
Likewise this could be a functional change
|
Test build #86447 has finished for PR 20344 at commit
|
|
Test build #86466 has finished for PR 20344 at commit
|
|
The builds failed due to a change in the error messages that the tests assert (!) Fixing... |
|
Test build #4070 has finished for PR 20344 at commit
|
|
Test build #86486 has finished for PR 20344 at commit
|
|
Merged to master/2.3 |
|
Test build #4071 has finished for PR 20344 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Typo fixes
How was this patch tested?
Local build / Doc-only changes