[SPARK-2967][SQL] Fix sort based shuffle for spark sql. #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA tests have started for PR 2066 at commit
|
|
LGTM |
|
QA tests have finished for PR 2066 at commit
|
|
Thanks for looking this over! Merged to master and 1.1 |
asfgit
pushed a commit
that referenced
this pull request
Aug 20, 2014
Add explicit row copies when sort based shuffle is on. Author: Michael Armbrust <michael@databricks.com> Closes #2066 from marmbrus/sortShuffle and squashes the following commits: fcd7bb2 [Michael Armbrust] Fix sort based shuffle for spark sql. (cherry picked from commit a2e658d) Signed-off-by: Michael Armbrust <michael@databricks.com>
| val mutablePair = new MutablePair[Row, Row]() | ||
| iter.map(r => mutablePair.update(hashExpressions(r), r)) | ||
| if (sortBasedShuffleOn) { | ||
| iter.map(r => (hashExpressions(r), r.copy())) |
There was a problem hiding this comment.
Hi, don't we need to copy hashExpressions(r) here?
There was a problem hiding this comment.
Good catch! Fixed here: #2072
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
Add explicit row copies when sort based shuffle is on. Author: Michael Armbrust <michael@databricks.com> Closes apache#2066 from marmbrus/sortShuffle and squashes the following commits: fcd7bb2 [Michael Armbrust] Fix sort based shuffle for spark sql.
xiliu82
pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
… shuffle fix. Follow-up to apache#2066 Author: Michael Armbrust <michael@databricks.com> Closes apache#2072 from marmbrus/sortShuffle and squashes the following commits: 2ff8114 [Michael Armbrust] Fix bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit row copies when sort based shuffle is on.