[SPARK-23523] [SQL] Fix the incorrect result caused by the rule OptimizeMetadataOnlyQuery #20684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
commented
Feb 27, 2018
| relation.output.filter(a => partColumns.contains(a.name.toLowerCase)) | ||
| val attrMap = relation.output.map(_.name).zip(relation.output).toMap | ||
| partitionColumnNames.map { colName => | ||
| attrMap.getOrElse(colName, |
There was a problem hiding this comment.
Do we need to consider the case sensitivity when comparing the names? cc @cloud-fan
|
good catch! LGTM |
|
Test build #87707 has finished for PR 20684 at commit
|
|
Test build #87700 has finished for PR 20684 at commit
|
|
retest this please. |
|
Test build #87708 has finished for PR 20684 at commit
|
|
Test build #87709 has finished for PR 20684 at commit
|
|
retest this please |
|
Test build #87716 has finished for PR 20684 at commit
|
|
Hi, @gatorsmile and @cloud-fan . |
|
We are still waiting for the official announcement of Spark 2.3 release. This will be merged to 2.3.1 for sure. |
|
I see. Thank you for confirmation, @gatorsmile ! |
|
Gentle ping, @gatorsmile since 2.3 is announced officially yesterday. |
gatorsmile
added a commit
to gatorsmile/spark
that referenced
this pull request
Mar 7, 2018
…zeMetadataOnlyQuery
## What changes were proposed in this pull request?
```Scala
val tablePath = new File(s"${path.getCanonicalPath}/cOl3=c/cOl1=a/cOl5=e")
Seq(("a", "b", "c", "d", "e")).toDF("cOl1", "cOl2", "cOl3", "cOl4", "cOl5")
.write.json(tablePath.getCanonicalPath)
val df = spark.read.json(path.getCanonicalPath).select("CoL1", "CoL5", "CoL3").distinct()
df.show()
```
It generates a wrong result.
```
[c,e,a]
```
We have a bug in the rule `OptimizeMetadataOnlyQuery `. We should respect the attribute order in the original leaf node. This PR is to fix it.
## How was this patch tested?
Added a test case
Author: gatorsmile <gatorsmile@gmail.com>
Closes apache#20684 from gatorsmile/optimizeMetadataOnly.
asfgit
pushed a commit
that referenced
this pull request
Mar 13, 2018
…he rule OptimizeMetadataOnlyQuery This PR is to backport #20684 and #20693 to Spark 2.3 branch --- ## What changes were proposed in this pull request? ```Scala val tablePath = new File(s"${path.getCanonicalPath}/cOl3=c/cOl1=a/cOl5=e") Seq(("a", "b", "c", "d", "e")).toDF("cOl1", "cOl2", "cOl3", "cOl4", "cOl5") .write.json(tablePath.getCanonicalPath) val df = spark.read.json(path.getCanonicalPath).select("CoL1", "CoL5", "CoL3").distinct() df.show() ``` It generates a wrong result. ``` [c,e,a] ``` We have a bug in the rule `OptimizeMetadataOnlyQuery `. We should respect the attribute order in the original leaf node. This PR is to fix it. ## How was this patch tested? Added a test case Author: Xingbo Jiang <xingbo.jiang@databricks.com> Author: gatorsmile <gatorsmile@gmail.com> Closes #20763 from gatorsmile/backport23523.
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
…zeMetadataOnlyQuery
## What changes were proposed in this pull request?
```Scala
val tablePath = new File(s"${path.getCanonicalPath}/cOl3=c/cOl1=a/cOl5=e")
Seq(("a", "b", "c", "d", "e")).toDF("cOl1", "cOl2", "cOl3", "cOl4", "cOl5")
.write.json(tablePath.getCanonicalPath)
val df = spark.read.json(path.getCanonicalPath).select("CoL1", "CoL5", "CoL3").distinct()
df.show()
```
It generates a wrong result.
```
[c,e,a]
```
We have a bug in the rule `OptimizeMetadataOnlyQuery `. We should respect the attribute order in the original leaf node. This PR is to fix it.
## How was this patch tested?
Added a test case
Author: gatorsmile <gatorsmile@gmail.com>
Closes apache#20684 from gatorsmile/optimizeMetadataOnly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It generates a wrong result.
We have a bug in the rule
OptimizeMetadataOnlyQuery. We should respect the attribute order in the original leaf node. This PR is to fix it.How was this patch tested?
Added a test case