[SPARK-23547][SQL]Cleanup the .pipeout file when the Hive Session closed #20702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attilapiros
reviewed
Mar 1, 2018
| String lScratchDir = hiveConf.getVar(ConfVars.LOCALSCRATCHDIR); | ||
| String sessionID = hiveConf.getVar(ConfVars.HIVESESSIONID); | ||
|
|
||
| File[] fileAry = new File(lScratchDir).listFiles( |
There was a problem hiding this comment.
Nit: There is an overloaded version of listfiles.
Using it saves 1 line.
There was a problem hiding this comment.
Sorry i did not find the overloaded version of listfiles which saves 1 line.
There was a problem hiding this comment.
No problem. I hope this works.
File[] fileAry = new File(lScratchDir).listFiles(
(dir, name) -> name.startsWith(sessionID) && name.endsWith(".pipeout"));
I think it would be good if you would have one unit test for your change.
There was a problem hiding this comment.
@attilapiros will fix it, thanks!
|
Jenkins, ok to test |
|
@gatorsmile @liufengdb could you please take a look at this, thanks! |
|
@cloud-fan @felixcheung would you please take a review. Thanks! |
|
ok to test |
|
cc @liufengdb |
|
Test build #88195 has finished for PR 20702 at commit
|
|
lgtm! |
|
thanks, merging to master! |
mstewart141
pushed a commit
to mstewart141/spark
that referenced
this pull request
Mar 24, 2018
…osed ## What changes were proposed in this pull request?  when the hive session closed, we should also cleanup the .pipeout file. ## How was this patch tested? Added test cases. Author: zuotingbing <zuo.tingbing9@zte.com.cn> Closes apache#20702 from zuotingbing/SPARK-23547.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
when the hive session closed, we should also cleanup the .pipeout file.
How was this patch tested?
Added test cases.