[SPARK-20536][SQL] Extend ColumnName to create StructFields with explicit nullable #20832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1208,85 +1208,172 @@ class ColumnName(name: String) extends Column(name) { | |||
| */ | |||
| def boolean: StructField = StructField(name, BooleanType) | |||
|
|
|||
| /** | |||
| * Creates a new `StructField` of type boolean. | |||
| * @since 2.3.0 | |||
| /** | ||
| * Creates a new `StructField` of type byte. | ||
| * @since 1.3.0 | ||
| */ | ||
| def byte: StructField = StructField(name, ByteType) | ||
|
|
||
| /** | ||
| * Creates a new `StructField` of type byte. | ||
| * @since 2.3.0 |
There was a problem hiding this comment.
2.4.0 and in the other places too (unless they patch 2.3.0 and becomes 2.3.1).
jaceklaskowski
approved these changes
Mar 18, 2018
|
Can one of the admins verify this patch? |
gatorsmile
reviewed
Oct 6, 2018
| * Creates a new `StructField` of type boolean. | ||
| * @since 2.4.0 | ||
| */ | ||
| def boolean(nullable: Boolean): StructField = StructField(name, BooleanType, nullable) |
There was a problem hiding this comment.
The NULL hints are not enforced. Thus, it is kind of risky to expose this to end users since it could generate a wrong result. We plan to ignore the user-specified NULL hints in the upcoming release.
|
@efimpoberezkin Could you please close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extended ColumnName with methods that create StructFields with explicit nullable property
How was this patch tested?
Existing tests