[SPARK-23565] [SS] New error message for structured streaming sources assertion #20946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r a query changes
There was a problem hiding this comment.
Change the title to '[SPARK-23565][SS]...' is more accurate.
| @@ -39,7 +39,9 @@ case class OffsetSeq(offsets: Seq[Option[Offset]], metadata: Option[OffsetSeqMet | |||
| * cannot be serialized). | |||
| */ | |||
| def toStreamProgress(sources: Seq[BaseStreamingSource]): StreamProgress = { | |||
| assert(sources.size == offsets.size) | |||
| assert(sources.size == offsets.size, s"There are [${offsets.size}] sources in the " + | |||
| s"checkpoint offsets and now there are [${sources.size}] sources requested by the query. " + | |||
There was a problem hiding this comment.
nit: extra blank in the end
| @@ -125,6 +125,19 @@ class OffsetSeqLogSuite extends SparkFunSuite with SharedSQLContext { | |||
| assert(offsetSeq.metadata === Some(OffsetSeqMetadata(0L, 1480981499528L))) | |||
| } | |||
|
|
|||
| test("assertion that number of checkpoint offsets match number of sources") { | |||
There was a problem hiding this comment.
Maybe no need to add UT for the log change.
patrickmcgloin
changed the title
|
Hi Xuan, I have updated the title, removed the extra white space after the period / dot and removed the UT. |
|
Hi @xuanyuanking, please see comments above. |
xuanyuanking
approved these changes
Apr 26, 2018
There was a problem hiding this comment.
+1 To me, useful in SS debugging, cc @cloud-fan to take a look.
|
cc @zsxwing |
|
okey to test LGTM |
|
ok to test |
|
Test build #89881 has finished for PR 20946 at commit
|
|
Thanks! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A more informative message to tell you why a structured streaming query cannot continue if you have added more sources, than there are in the existing checkpoint offsets.
How was this patch tested?
I added a Unit Test.