Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-23748][SS] Fix SS continuous process doesn't support SubqueryAlias issue #21017

Closed
wants to merge 1 commit into from

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

Current SS continuous doesn't support processing on temp table or df.as("xxx"), SS will throw an exception as LogicalPlan not supported, details described in here.

So here propose to add this support.

How was this patch tested?

new UT.

@SparkQA
Copy link

SparkQA commented Apr 10, 2018

Test build #89082 has finished for PR 21017 at commit 03ca4ec.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Apr 10, 2018

Test build #89086 has finished for PR 21017 at commit 03ca4ec.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Apr 10, 2018

Test build #89096 has finished for PR 21017 at commit 03ca4ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao
Copy link
Contributor Author

@jose-torres @tdas would you please help to review, thanks!

@jose-torres
Copy link
Contributor

LGTM

@jerryshao
Copy link
Contributor Author

Thanks @jose-torres for your review.

@tdas would you please take a look at this PR?

@tdas
Copy link
Contributor

tdas commented Apr 13, 2018

LGTM. Merging this to master and 2.3

asfgit pushed a commit that referenced this pull request Apr 13, 2018
…lias issue

## What changes were proposed in this pull request?

Current SS continuous doesn't support processing on temp table or `df.as("xxx")`, SS will throw an exception as LogicalPlan not supported, details described in [here](https://issues.apache.org/jira/browse/SPARK-23748).

So here propose to add this support.

## How was this patch tested?

new UT.

Author: jerryshao <sshao@hortonworks.com>

Closes #21017 from jerryshao/SPARK-23748.

(cherry picked from commit 14291b0)
Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
@asfgit asfgit closed this in 14291b0 Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants