[SPARK-23589][SQL][FOLLOW-UP] Reuse InternalRow in ExternalMapToCatalyst eval #21137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #89760 has finished for PR 21137 at commit
|
|
retest this please |
hvanhovell
reviewed
Apr 24, 2018
| @@ -1255,6 +1255,13 @@ case class ExternalMapToCatalyst private( | |||
| override def dataType: MapType = MapType( | |||
| keyConverter.dataType, valueConverter.dataType, valueContainsNull = valueConverter.nullable) | |||
|
|
|||
| private lazy val rowBuffer = InternalRow.fromSeq(Array[Any](1)) | |||
There was a problem hiding this comment.
We don't need to make this expression wide state. Just move this inside the mapCatalystConverter def.
hvanhovell
reviewed
Apr 24, 2018
| } else { | ||
| throw new RuntimeException("Cannot use null as map key!") | ||
| } | ||
| values(i) = if (value != null) { | ||
| valueConverter.eval(InternalRow.fromSeq(value :: Nil)) | ||
| valueConverter.eval(rowWrapper(value)) |
There was a problem hiding this comment.
Can you also change lines 1299 & 1304?
hvanhovell
approved these changes
Apr 24, 2018
|
Test build #89770 has finished for PR 21137 at commit
|
|
Test build #89779 has finished for PR 21137 at commit
|
|
Merging to master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr is a follow-up of #20980 and fixes code to reuse
InternalRowfor converting input keys/values inExternalMapToCatalysteval.How was this patch tested?
Existing tests.