[SPARK-23830][YARN] added check to ensure main method is found #21168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Apr 26, 2018
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
Outdated
Show resolved
Hide resolved
|
The exception happens because |
vanzin
reviewed
Apr 26, 2018
| finish(FinalApplicationStatus.SUCCEEDED, ApplicationMaster.EXIT_SUCCESS) | ||
| logDebug("Done running users class") | ||
| if(!Modifier.isStatic(mainMethod.getModifiers)) { | ||
| logError(s"Could not find main method in object ${args.userClass}") |
There was a problem hiding this comment.
The message could be a little more helpful here.
| mainMethod.invoke(null, userArgs.toArray) | ||
| finish(FinalApplicationStatus.SUCCEEDED, ApplicationMaster.EXIT_SUCCESS) | ||
| logDebug("Done running users class") | ||
| if(!Modifier.isStatic(mainMethod.getModifiers)) { |
There was a problem hiding this comment.
This won't pass the style checker...
|
ok to test |
|
Test build #89910 has finished for PR 21168 at commit
|
eric-maynard
changed the title
|
Test build #89911 has finished for PR 21168 at commit
|
|
The change is fail to build, please fix it. |
|
Also this is a yarn, not core, change. |
eric-maynard
changed the title
added an import for `java.lang.reflect.Modifier`
|
Test build #89913 has finished for PR 21168 at commit
|
jerryshao
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When a user specifies the wrong class -- or, in fact, a class instead of an object -- Spark throws an NPE which is not useful for debugging. This was reported in SPARK-23830. This PR adds a check to ensure the main method was found and logs a useful error in the event that it's null.
How was this patch tested?