[SPARK-24168][SQL] WindowExec should not access SQLConf at executor side #21225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #90097 has finished for PR 21225 at commit
|
|
retest this please |
|
Test build #90106 has finished for PR 21225 at commit
|
|
Test build #90103 has finished for PR 21225 at commit
|
|
retest this please. |
jiangxb1987
reviewed
May 3, 2018
| @@ -114,7 +114,8 @@ case class WindowExec( | |||
| * @param bound with respect to the row. | |||
There was a problem hiding this comment.
nit: add param timeZone.
|
Test build #90113 has finished for PR 21225 at commit
|
|
LGTM |
hvanhovell
reviewed
May 3, 2018
| @@ -197,6 +198,7 @@ case class WindowExec( | |||
|
|
|||
| // Map the groups to a (unbound) expression and frame factory pair. | |||
| var numExpressions = 0 | |||
| val timeZone = conf.sessionLocalTimeZone | |||
There was a problem hiding this comment.
NIT: should we also touch up the use of sqlContext.conf in doExecute()?
There was a problem hiding this comment.
that one is OK because it's not in a closure and passed to executors.
|
Test build #90141 has finished for PR 21225 at commit
|
|
retest this please |
|
Test build #90158 has finished for PR 21225 at commit
|
|
Thanks! Merged to master/2.3 |
asfgit
pushed a commit
that referenced
this pull request
May 4, 2018
## What changes were proposed in this pull request? This PR is extracted from #21190 , to make it easier to backport. `WindowExec#createBoundOrdering` is called on executor side, so we can't use `conf.sessionLocalTimezone` there. ## How was this patch tested? tested in #21190 Author: Wenchen Fan <wenchen@databricks.com> Closes #21225 from cloud-fan/minor3. (cherry picked from commit e646ae6) Signed-off-by: gatorsmile <gatorsmile@gmail.com>
zzcclp
pushed a commit
to zzcclp/spark
that referenced
this pull request
May 11, 2018
… on the driver ## What changes were proposed in this pull request? This is a followup of apache#20136 . apache#20136 didn't really work because in the test, we are using local backend, which shares the driver side `SparkEnv`, so `SparkEnv.get.executorId == SparkContext.DRIVER_IDENTIFIER` doesn't work. This PR changes the check to `TaskContext.get != null`, and move the check to `SQLConf.get`, and fix all the places that violate this check: * `InMemoryTableScanExec#createAndDecompressColumn` is executed inside `rdd.map`, we can't access `conf.offHeapColumnVectorEnabled` there. apache#21223 merged * `DataType#sameType` may be executed in executor side, for things like json schema inference, so we can't call `conf.caseSensitiveAnalysis` there. This contributes to most of the code changes, as we need to add `caseSensitive` parameter to a lot of methods. * `ParquetFilters` is used in the file scan function, which is executed in executor side, so we can't can't call `conf.parquetFilterPushDownDate` there. apache#21224 merged * `WindowExec#createBoundOrdering` is called on executor side, so we can't use `conf.sessionLocalTimezone` there. apache#21225 merged * `JsonToStructs` can be serialized to executors and evaluate, we should not call `SQLConf.get.getConf(SQLConf.FROM_JSON_FORCE_NULLABLE_SCHEMA)` in the body. apache#21226 merged ## How was this patch tested? existing test Author: Wenchen Fan <wenchen@databricks.com> Closes apache#21190 from cloud-fan/minor.
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 24, 2018
… on the driver ## What changes were proposed in this pull request? This is a followup of apache#20136 . apache#20136 didn't really work because in the test, we are using local backend, which shares the driver side `SparkEnv`, so `SparkEnv.get.executorId == SparkContext.DRIVER_IDENTIFIER` doesn't work. This PR changes the check to `TaskContext.get != null`, and move the check to `SQLConf.get`, and fix all the places that violate this check: * `InMemoryTableScanExec#createAndDecompressColumn` is executed inside `rdd.map`, we can't access `conf.offHeapColumnVectorEnabled` there. apache#21223 merged * `DataType#sameType` may be executed in executor side, for things like json schema inference, so we can't call `conf.caseSensitiveAnalysis` there. This contributes to most of the code changes, as we need to add `caseSensitive` parameter to a lot of methods. * `ParquetFilters` is used in the file scan function, which is executed in executor side, so we can't can't call `conf.parquetFilterPushDownDate` there. apache#21224 merged * `WindowExec#createBoundOrdering` is called on executor side, so we can't use `conf.sessionLocalTimezone` there. apache#21225 merged * `JsonToStructs` can be serialized to executors and evaluate, we should not call `SQLConf.get.getConf(SQLConf.FROM_JSON_FORCE_NULLABLE_SCHEMA)` in the body. apache#21226 merged ## How was this patch tested? existing test Author: Wenchen Fan <wenchen@databricks.com> Closes apache#21190 from cloud-fan/minor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is extracted from #21190 , to make it easier to backport.
WindowExec#createBoundOrderingis called on executor side, so we can't useconf.sessionLocalTimezonethere.How was this patch tested?
tested in #21190