Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-24317][SQL]Float-point numbers are displayed with different precision in ThriftServer2 #21364

Closed
wants to merge 1 commit into from

Conversation

cxzl25
Copy link
Contributor

@cxzl25 cxzl25 commented May 18, 2018

What changes were proposed in this pull request?

When querying float-point numbers , the values displayed on beeline or jdbc are with different precision.

SELECT CAST(1.23 AS FLOAT)
Result:
1.2300000190734863

According to these two jira:
HIVE-11802
HIVE-11832
Make a slight modification to the spark hive thrift server.

How was this patch tested?

HiveThriftBinaryServerSuite
test("JDBC query float-point number")

@cxzl25 cxzl25 changed the title [SPARK-20173][SQL]Float-point numbers are displayed with different precision in ThriftServer2 [SPARK-24317][SQL]Float-point numbers are displayed with different precision in ThriftServer2 May 18, 2018
@cxzl25 cxzl25 closed this May 18, 2018
@cxzl25 cxzl25 reopened this May 18, 2018
@mgaido91
Copy link
Contributor

the change itself LGTM, cc @cloud-fan @gatorsmile: can we trigger a build for this?

@gatorsmile
Copy link
Member

ok to test

@gatorsmile
Copy link
Member

cc @liufengdb

@SparkQA
Copy link

SparkQA commented May 18, 2018

Test build #90811 has finished for PR 21364 at commit 137abed.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cxzl25
Copy link
Contributor Author

cxzl25 commented May 28, 2018

@gatorsmile @liufengdb @cloud-fan
Could you please give some comments when you have time?
Thanks so much.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@cxzl25 cxzl25 closed this Oct 11, 2018
@gatorsmile
Copy link
Member

cc @srinathshankar @yuchenhuo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants