Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR][CORE][TEST] Remove unnecessary sort in UnsafeInMemorySorterSuite #21536

Closed
wants to merge 1 commit into from
Closed

[MINOR][CORE][TEST] Remove unnecessary sort in UnsafeInMemorySorterSuite #21536

wants to merge 1 commit into from

Conversation

jiangxb1987
Copy link
Contributor

What changes were proposed in this pull request?

We don't require specific ordering of the input data, the sort action is not necessary and misleading.

How was this patch tested?

Existing test suite.

@SparkQA
Copy link

SparkQA commented Jun 12, 2018

Test build #91691 has finished for PR 21536 at commit 2ea2181.

  • This patch fails Java style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Hm .. ? retest this please

@SparkQA
Copy link

SparkQA commented Jun 12, 2018

Test build #91695 has finished for PR 21536 at commit 2ea2181.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jiangxb1987
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Jun 12, 2018

Test build #91721 has finished for PR 21536 at commit 2ea2181.

  • This patch fails Java style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jiangxb1987
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Jun 13, 2018

Test build #91746 has finished for PR 21536 at commit 2ea2181.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jiangxb1987
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Jun 13, 2018

Test build #91753 has finished for PR 21536 at commit 2ea2181.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jiangxb1987
Copy link
Contributor Author

@HyukjinKwon can we merge this?

@HyukjinKwon
Copy link
Member

Sure.

HyukjinKwon
HyukjinKwon approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon
Copy link
Member

Merged to master and branch-2.3.

asfgit pushed a commit that referenced this pull request Jun 14, 2018
@jiangxb1987 @HyukjinKwon
[MINOR][CORE][TEST] Remove unnecessary sort in UnsafeInMemorySorterSuite
a2f65eb 
## What changes were proposed in this pull request?

We don't require specific ordering of the input data, the sort action is not necessary and misleading.

## How was this patch tested?

Existing test suite.

Author: Xingbo Jiang <xingbo.jiang@databricks.com>

Closes #21536 from jiangxb1987/sorterSuite.

(cherry picked from commit 534065e)
Signed-off-by: hyukjinkwon <gurwls223@apache.org>
@asfgit asfgit closed this in 534065e Jun 14, 2018
@jiangxb1987
Copy link
Contributor Author

Thanks! @HyukjinKwon

@jiangxb1987 jiangxb1987 deleted the sorterSuite branch June 14, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jiangxb1987 @SparkQA @HyukjinKwon