[K8S] Fix issue in 'docker-image-tool.sh' #21551
Conversation
Because of the missing assignment of the variable `BUILD_ARGS` the command `./bin/docker-image-tool.sh -r docker.io/myrepo -t v2.3.0 build` fails: ``` docker build" requires exactly 1 argument. See 'docker build --help'. Usage: docker build [OPTIONS] PATH | URL | - [flags] Build an image from a Dockerfile ``` This has been fixed on the `master` already but, apparently, it has not been ported back to the branch `2.3`, leading to the same error even on the latest `2.3.1` release (dated 8 June 2018).
|
ouch |
|
ok to test |
|
Test build #91967 has finished for PR 21551 at commit
|
|
@rxin for SA that this is going into branch-2.3. Should be fine - we can ship this if/when we cut 2.3.2. Merging. |
Because of the missing assignment of the variable `BUILD_ARGS` the command `./bin/docker-image-tool.sh -r docker.io/myrepo -t v2.3.1 build` fails: ``` docker build" requires exactly 1 argument. See 'docker build --help'. Usage: docker build [OPTIONS] PATH | URL | - [flags] Build an image from a Dockerfile ``` This has been fixed on the `master` already but, apparently, it has not been ported back to the branch `2.3`, leading to the same error even on the latest `2.3.1` release (dated 8 June 2018). Author: Fabrizio Cucci <fabrizio.cucci@gmail.com> Closes #21551 from fabriziocucci/patch-1.
|
Missed this before merging, but @fabriziocucci for future reference please put the ticket number along with |
fabriziocucci
changed the title
|
The PR is already merged so it's too late now. Next time, please create a ticket if one does not exist and put it in the PR description. |
|
Duly noted! 👍 |
|
@mccheah this isn't showing as merged, you said you ran the merge script? |
|
Hm, I thought I did. I don't quite know what's going on. |
|
asfgit is showing the commit as pushed above. |
|
OK, I see it referenced above as commit b8dbfcc. I'd close this, but that option is disabled for me. Probably assuming it happens from the merge-pr script. |
|
@fabriziocucci can you close this PR? |
|
FYI, PRs against non-master branches need to be manually closed. Don't know the exact explanation for why that's the case. |
|
Phew, this was a bad one. Thanks for the fix all. |
Because of the missing assignment of the variable
BUILD_ARGSthe command./bin/docker-image-tool.sh -r docker.io/myrepo -t v2.3.1 buildfails:This has been fixed on the
masteralready but, apparently, it has not been ported back to the branch2.3, leading to the same error even on the latest2.3.1release (dated 8 June 2018).