Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-3264] Allow users to set executor Spark home in Mesos #2166

Closed
wants to merge 3 commits into from

Conversation

andrewor14
Copy link
Contributor

The executors and the driver may not share the same Spark home. There is currently one way to set the executor side Spark home in Mesos, through setting spark.home. However, this is neither documented nor intuitive. This PR adds a more specific config spark.mesos.executor.home and exposes this to the user.

@liancheng @tnachen

@andrewor14
Copy link
Contributor Author

test this please

@SparkQA
Copy link

SparkQA commented Aug 27, 2014

QA tests have started for PR 2166 at commit b87965e.

  • This patch merges cleanly.

@liancheng
Copy link
Contributor

Should we mark spark.home as deprecated?

@SparkQA
Copy link

SparkQA commented Aug 27, 2014

QA tests have finished for PR 2166 at commit b87965e.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor Author

spark.home is not documented in the first place, so I think it's fine to leave it

@liancheng
Copy link
Contributor

Then it still would be good to mark it as deprecated in SparkContext.getSparkHome, so that other developers won't rely on it in the future.

@tnachen
Copy link
Contributor

tnachen commented Aug 28, 2014

the patch looks good to me, I don't think this requires a cluster test.

@mattf
Copy link
Contributor

mattf commented Aug 28, 2014

lgtm, nice idea

i've been using rpm installed spark, which provides a single version and location on all nodes. however, this will make for a clear path to running multiple versions of spark on a mesos cluster.

@andrewor14
Copy link
Contributor Author

Thanks, I'm merging this into master and 1.1.

@liancheng spark.home is actually used in a few other places too, though largely in tests. It would be a non-trivial to figure out a good way to deprecate this (unfortunately). I have actually attempted this in a prior PR (#1734) but to no avail. :( I prefer to address that separately.

@tnachen If you have the cycles, would you mind updating running-on-mesos.md to reflect this change? I would do it but I do not have enough expertise or experience in running Spark on Mesos.

@mattf Great to know this helps your use case.

asfgit pushed a commit that referenced this pull request Aug 28, 2014
The executors and the driver may not share the same Spark home. There is currently one way to set the executor side Spark home in Mesos, through setting `spark.home`. However, this is neither documented nor intuitive. This PR adds a more specific config `spark.mesos.executor.home` and exposes this to the user.

liancheng tnachen

Author: Andrew Or <andrewor14@gmail.com>

Closes #2166 from andrewor14/mesos-spark-home and squashes the following commits:

b87965e [Andrew Or] Merge branch 'master' of github.com:apache/spark into mesos-spark-home
f6abb2e [Andrew Or] Document spark.mesos.executor.home
ca7846d [Andrew Or] Add more specific configuration for executor Spark home in Mesos

(cherry picked from commit 41dc598)
Signed-off-by: Andrew Or <andrewor14@gmail.com>
@asfgit asfgit closed this in 41dc598 Aug 28, 2014
@andrewor14 andrewor14 deleted the mesos-spark-home branch August 28, 2014 18:06
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
The executors and the driver may not share the same Spark home. There is currently one way to set the executor side Spark home in Mesos, through setting `spark.home`. However, this is neither documented nor intuitive. This PR adds a more specific config `spark.mesos.executor.home` and exposes this to the user.

liancheng tnachen

Author: Andrew Or <andrewor14@gmail.com>

Closes apache#2166 from andrewor14/mesos-spark-home and squashes the following commits:

b87965e [Andrew Or] Merge branch 'master' of github.com:apache/spark into mesos-spark-home
f6abb2e [Andrew Or] Document spark.mesos.executor.home
ca7846d [Andrew Or] Add more specific configuration for executor Spark home in Mesos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants