Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARK-24714 AnalysisSuite should use ClassTag to check the runtime in… #21694

Closed
wants to merge 1 commit into from
Closed

SPARK-24714 AnalysisSuite should use ClassTag to check the runtime in… #21694

wants to merge 1 commit into from

Conversation

chia7712
Copy link
Contributor

@chia7712 chia7712 commented Jul 2, 2018

…stance

What changes were proposed in this pull request?

Use scala classTag to do the type check.

How was this patch tested?

this PR is against test

Please review http://spark.apache.org/contributing.html before opening a pull request.

@maropu
Copy link
Member

maropu commented Jul 2, 2018

I'm not sure this issue should be fixed for test code qualities though, I have one question; is this only a place having this issue?

@chia7712
Copy link
Contributor Author

chia7712 commented Jul 2, 2018

I have one question; is this only a place having this issue?`

I grepped the code base by "isInstanceOf[T]". Only one result appears and this PR have fixed it.

@chia7712
Copy link
Contributor Author

chia7712 commented Jul 2, 2018

I'm not sure this issue should be fixed for test code qualities though

the bug is obvious but it doesn't impact the test case. At any rate, I'm ok to decline this PR :)

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Jan 10, 2020
@maropu maropu closed this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants