Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-24711][K8S] Fix tags for integration tests #21697

Closed
wants to merge 1 commit into from

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jul 2, 2018

What changes were proposed in this pull request?

How was this patch tested?

Manually by adding tags.

@skonto
Copy link
Contributor Author

skonto commented Jul 2, 2018

@ssuchter @foxish @felixcheung pls review.

@SparkQA
Copy link

SparkQA commented Jul 2, 2018

@SparkQA
Copy link

SparkQA commented Jul 2, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/618/

@SparkQA
Copy link

SparkQA commented Jul 2, 2018

@SparkQA
Copy link

SparkQA commented Jul 2, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/619/

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>2.22.0</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we declare the version in the parent POM? (or should). OK to update it while you're at it to the latest version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sure will do.

@SparkQA
Copy link

SparkQA commented Jul 2, 2018

Test build #92525 has finished for PR 21697 at commit 6dc71e5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@foxish
Copy link
Contributor

foxish commented Jul 2, 2018

This is good! Same comment that @srowen had on moving the version up to the parent POM and referencing it here.

@skonto
Copy link
Contributor Author

skonto commented Jul 2, 2018

Thanks @foxish will update the PR.

@SparkQA
Copy link

SparkQA commented Jul 4, 2018

@SparkQA
Copy link

SparkQA commented Jul 4, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/685/

@skonto
Copy link
Contributor Author

skonto commented Jul 4, 2018

@srowen I moved the version to the parent pom. Should I update the version here too?

@SparkQA
Copy link

SparkQA commented Jul 4, 2018

@SparkQA
Copy link

SparkQA commented Jul 4, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/687/

pom.xml Outdated
@@ -114,6 +114,7 @@
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<maven.version>3.3.9</maven.version>
<maven.surefire.plugin.version>2.22.0</maven.surefire.plugin.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parent POM here already declares the surefire plugin, but version 2.20.1. That would need to be changed. If you do, you don't need a version in the child POM, nor do you really need a property to control the version and the extra indirection.

Copy link
Contributor Author

@skonto skonto Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but I thought you wanted me to add that version at the parent pom as a property. Ok, I will update the version only in the parent and remove the version from the child pom.

@SparkQA
Copy link

SparkQA commented Jul 4, 2018

Test build #92622 has finished for PR 21697 at commit ed8a697.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 4, 2018

Test build #92624 has finished for PR 21697 at commit e9eb789.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@skonto
Copy link
Contributor Author

skonto commented Jul 5, 2018

@srowen fixed it, ready for final review/merge.

@SparkQA
Copy link

SparkQA commented Jul 5, 2018

@SparkQA
Copy link

SparkQA commented Jul 5, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/706/

@srowen
Copy link
Member

srowen commented Jul 5, 2018

Merged to master

@asfgit asfgit closed this in 7bd6d54 Jul 5, 2018
@SparkQA
Copy link

SparkQA commented Jul 5, 2018

Test build #92646 has finished for PR 21697 at commit f61f2ce.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants