Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-24825][K8S][TEST] Kubernetes integration tests build the whole reactor #21800

Closed

Conversation

mccheah
Copy link
Contributor

@mccheah mccheah commented Jul 18, 2018

What changes were proposed in this pull request?

Make the integration test script build all modules.

In order to not run all the non-Kubernetes integration tests in the build, support specifying tags and tag all integration tests specifically with "k8s". Supply the k8s tag in the dev/dev-run-integration-tests.sh script.

How was this patch tested?

The build system will test this.

… reactor.

In order to not run all the non-Kubernetes integration tests in the build, support specifying tags and tag all integration tests specifically with "k8s". Supply the k8s tag in the dev/dev-run-integration-tests.sh script.
@mccheah
Copy link
Contributor Author

mccheah commented Jul 18, 2018

test this please

@shaneknapp
Copy link
Contributor

quick comment (from @jey ):

add set -x to the top (after the shebang) of resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh

this way we can see what's happening in that script during the build.

@SparkQA
Copy link

SparkQA commented Jul 18, 2018

@jey
Copy link
Contributor

jey commented Jul 18, 2018

To add to @shaneknapp's comment, please add set -o errexit to your shell script so that it will exit with a nonzero code if any of its commands fail. The absence of this causes the tests to claim to pass even when there's an error, since the dev-run-integration-tests.sh still returns a 0 exit code.

fi

../../../build/mvn integration-test ${properties[@]}
$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests -am -Pkubernetes -Phadoop-2.7 ${properties[@]}
Copy link
Contributor

@skonto skonto Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. We need to skip top level unit tests here I guess tags do that. I was wondering if there is another way.

@SparkQA
Copy link

SparkQA commented Jul 18, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/1080/

@mccheah
Copy link
Contributor Author

mccheah commented Jul 18, 2018

Addressed comments

@SparkQA
Copy link

SparkQA commented Jul 18, 2018

@SparkQA
Copy link

SparkQA commented Jul 18, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/1081/

@shaneknapp
Copy link
Contributor

LGTM

@SparkQA
Copy link

SparkQA commented Jul 18, 2018

Test build #93209 has finished for PR 21800 at commit 6a89c65.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 18, 2018

Test build #93210 has finished for PR 21800 at commit d6f41e0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in fc0c8c9 Jul 18, 2018
@robert3005 robert3005 deleted the k8s-integration-tests-maven-fix branch August 11, 2018 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants