New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-24825][K8S][TEST] Kubernetes integration tests build the whole reactor #21800
Conversation
… reactor. In order to not run all the non-Kubernetes integration tests in the build, support specifying tags and tag all integration tests specifically with "k8s". Supply the k8s tag in the dev/dev-run-integration-tests.sh script.
test this please |
quick comment (from @jey ): add this way we can see what's happening in that script during the build. |
Kubernetes integration test starting |
To add to @shaneknapp's comment, please add |
fi | ||
|
||
../../../build/mvn integration-test ${properties[@]} | ||
$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests -am -Pkubernetes -Phadoop-2.7 ${properties[@]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. We need to skip top level unit tests here I guess tags do that. I was wondering if there is another way.
Kubernetes integration test status success |
Addressed comments |
Kubernetes integration test starting |
Kubernetes integration test status success |
LGTM |
Test build #93209 has finished for PR 21800 at commit
|
Test build #93210 has finished for PR 21800 at commit
|
What changes were proposed in this pull request?
Make the integration test script build all modules.
In order to not run all the non-Kubernetes integration tests in the build, support specifying tags and tag all integration tests specifically with "k8s". Supply the k8s tag in the dev/dev-run-integration-tests.sh script.
How was this patch tested?
The build system will test this.